diff --git a/.trellis/workspace/hechang27-sprt/04-10-code-review.md b/.trellis/workspace/hechang27-sprt/04-10-code-review.md new file mode 100644 index 0000000..911c0a3 --- /dev/null +++ b/.trellis/workspace/hechang27-sprt/04-10-code-review.md @@ -0,0 +1,95 @@ + # Code review + + Found 4 urgent issues need to be fixed: + + ## 1 Dimension props regressed, so height/maxHeight no longer follow the old contract + + FilePath: packages/base/data/list-table-v2/list-table-v2.vue:291 line 291 + + if (props.height !== undefined) { + const h = String(props.height); + style.maxHeight = h.endsWith("px") ? h : `${h}px`; + } + // props.maxHeight handling is commented out + + height is being applied as maxHeight, maxHeight is ignored entirely, and minHeight is unused. The old component and the + demo page both rely on these props behaving distinctly, so PR2 currently breaks the documented sizing behavior. + + ### Suggested fix + + Restore the old container contract: set style.height from props.height, apply style.maxHeight from props.maxHeight, honor + props.minHeight, and keep viewportHeight derived from the actual constrained container size. + + ——— + + ## 2 rowKey is exposed but never used, so virtual rows are keyed by visible index + + FilePath: packages/base/data/list-table-v2/list-table-v2.vue:32 line 32 + +
# GitNexus — Code Intelligence -This project is indexed by GitNexus as **noob-components** (1086 symbols, 2384 relationships, 85 execution flows). Use the GitNexus MCP tools to understand code, assess impact, and navigate safely. +This project is indexed by GitNexus as **noob-components** (1066 symbols, 2354 relationships, 84 execution flows). Use the GitNexus MCP tools to understand code, assess impact, and navigate safely. > If any GitNexus tool warns the index is stale, run `npx gitnexus analyze` in terminal first. diff --git a/CLAUDE.md b/CLAUDE.md index 4b7b04e..11fb8c0 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -1,7 +1,7 @@ # GitNexus — Code Intelligence -This project is indexed by GitNexus as **noob-components** (1086 symbols, 2384 relationships, 85 execution flows). Use the GitNexus MCP tools to understand code, assess impact, and navigate safely. +This project is indexed by GitNexus as **noob-components** (1066 symbols, 2354 relationships, 84 execution flows). Use the GitNexus MCP tools to understand code, assess impact, and navigate safely. > If any GitNexus tool warns the index is stale, run `npx gitnexus analyze` in terminal first. diff --git a/packages/base/data/list-table-v2.vue b/packages/base/data/list-table-v2.vue deleted file mode 100644 index 85d32da..0000000 --- a/packages/base/data/list-table-v2.vue +++ /dev/null @@ -1,831 +0,0 @@ - - - - -